On Mon, Aug 27, 2012 at 6:33 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 08/25/2012 08:53 AM, Sebastian Hesselbarth wrote: >> >> now I do understand but in the current driver we pass pingroups associated >> with the available functions, i.e. "mpp2" with "uart1", "uart2", >> "sdio0", aso. >> IMHO for the above three functions it would be better to have functions >> associated >> with the corresponding groups, i.e. "uart1" with "mpp_uart1", "mpp2", >> "mpp3", aso. > > The pinctrl subsystem does expect a list of functions, and for each > function, a list of the groups where it can be selected. I admit that > when I think about this, it's slightly backward, since HW typically has > a list of pins/groups, and for each, a certain set of functions can be > selected. Oh well... I agree that this is how we engineered it, would it create big hassles for you to fix up the driver so it's the other way around Sebastian? I understand that the driver is perfectly working as it is, but from a subsystem maintainer point of view it is annoying if one driver turns the concepts around and it gets hard to maintain. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
