On Sun, 26 Aug 2012, Randy Dunlap wrote:
> On 08/26/2012 05:17 AM, Robert P. J. Day wrote:
>
> >
> > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> >
>
>
> It's interesting that the 'work' parameter is (always) unused
> AFAICT (in deferred work functions). Maybe some historical
> reason for it, but I dunno.
>
>
> > ---
> >
> > diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> > index e3bbed8..94e10cf 100644
> > --- a/drivers/base/dd.c
> > +++ b/drivers/base/dd.c
> > @@ -54,6 +54,7 @@ static struct workqueue_struct *deferred_wq;
> >
> > /**
> > * deferred_probe_work_func() - Retry probing devices in the active list.
> > + * @work: struct work_struct, defined in workqueue.h.
> > */
> > static void deferred_probe_work_func(struct work_struct *work)
> > {
i didn't even notice that, i'll check into its history. it's
possible that the parameter is removable but, at that point, it's an
actual functional change and i tried this morning to just keep things
kerneldoc-related to make sure i didn't break anything.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
