On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device
> tree bindings.
> Small change in wm8505-fb.c to support WM8650 framebuffer color
> format.
That might warrant a separate patch?
> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> + np = of_find_node_by_name(NULL, "display");
> + if (!np) {
> + pr_err("%s: No display description in Device Tree\n", __func__);
> + ret = -EINVAL;
> + goto failed_free_res;
> + }
I believe that using hard-coded node names is frowned upon. Better would
be to put a phandle into the display controller's node that points at
the node representing the display, e.g.:
fb@d800e400 {
compatible = "via,vt8500-fb";
reg = <0xd800e400 0x400>;
interrupts = <12>;
via,display = <&display>;
};
display: display {
...
};
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
