Hi, On Tue, Jul 10, 2012 at 11:43 AM, Rajendra Nayak <rnayak@xxxxxx> wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add twl4030-usb data node in twl4030 device tree file. >> >> Signed-off-by: Kishon Vijay Abraham I<kishon@xxxxxx> >> --- >> arch/arm/boot/dts/twl4030.dtsi | 21 +++++++++++++++++++++ >> 1 files changed, 21 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/twl4030.dtsi >> b/arch/arm/boot/dts/twl4030.dtsi >> index 22f4d13..66534a3 100644 >> --- a/arch/arm/boot/dts/twl4030.dtsi >> +++ b/arch/arm/boot/dts/twl4030.dtsi >> @@ -37,6 +37,18 @@ >> regulator-max-microvolt =<3150000>; >> }; >> >> + vusb1v5: regulator@3 { >> + compatible = "ti,twl4030-vusb1v5"; >> + }; > > > These @3, @4 are actually wrong since the node do > not have a 'reg' property in it. This was commented on > by David Brown on my original series which added this but > it somehow slipped through the cracks. I understand that > you would have looked up what existed in the file and > extended, but what already exists in the file needs to > be fixed up too. I'll send in a patch to fix those up. Ok. i'll follow suit :-) Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html