On Wed, Jun 27, 2012 at 4:15 PM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Wed, Jun 27, 2012 at 05:51:12PM +0200, Roland Stigge wrote: >> From: Alexandre Pereira da Silva <aletes.xgr@xxxxxxxxx> >> >> Since this driver depends on the amba pl08x dma driver, select it in Kconfig. >> >> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@xxxxxxxxx> >> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx> >> --- >> drivers/mtd/nand/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig >> index de69978..a9e8b73 100644 >> --- a/drivers/mtd/nand/Kconfig >> +++ b/drivers/mtd/nand/Kconfig >> @@ -417,6 +417,7 @@ config MTD_NAND_PXA3xx >> config MTD_NAND_SLC_LPC32XX >> tristate "NXP LPC32xx SLC Controller" >> depends on ARCH_LPC32XX >> + select AMBA_PL08X >> help >> Enables support for NXP's LPC32XX SLC (i.e. for Single Level Cell >> chips) NAND controller. This is the default for the PHYTEC 3250 > > Surely not? Drivers using DMA engine really should not depend on any > particular DMA engine implementation. Should the DMA code in this driver be ifdef'd like in spi-pl022.c? Or just depend on DMA_ENGINE instead? -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
