On Wed, Jun 27, 2012 at 9:14 AM, Roland Stigge <stigge@xxxxxxxxx> wrote: > On 06/27/2012 12:46 PM, Artem Bityutskiy wrote: >> On Thu, 2012-06-07 at 12:22 +0200, Roland Stigge wrote: >>> This patch adds support for the SLC NAND controller inside the >>> LPC32xx SoC. >>> >>> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx> >> >> Now the write_page and write_page_raw functions return an error >> code, see this commit in the l2 tree: >> >> http://git.infradead.org/users/dedekind/l2-mtd.git/commit/49c8d9ab3b70732665249f2d993f734378ebbba9 >> >> I've amended your SLC driver, see below the diff. But I think it >> could return the real return code becuse it can fail - could you >> please take a look and send an incremental patch? >> >> Please, base your work on top of the l2-mtd tree: >> git://git.infradead.org/users/dedekind/l2-mtd.git > > Thanks for the note! I'm sending an incremental patch. There was > actually only one place in the two functions that could fail (return > code of lpc32xx_xfer()). I think it's best in case of *_raw to use nand base default functions, like in the MLC patch. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
