Re: v2 [PATCH] Documentation: fix typos in Documentation/dvb/README.dvb-usb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2012-05-05 at 22:42 -0500, Rob Landley wrote:
> On 05/05/2012 09:10 PM, Shawn Landden wrote:
> >  Quite keen I wanted to put the driver (with some quirks of course) into dibusb.
> > -After reading some specs and doing some USB snooping, it realized, that the
> > +After reading some specs and doing some USB snooping, I realized, that the
> >  dibusb-driver would be a complete mess afterwards. So I decided to do it in a
> >  different way: With the help of a dvb-usb-framework.
> 
> But not taking out the comma after realized?
done
> 
> > @@ -115,7 +115,7 @@ http://www.linuxtv.org/wiki/index.php/DVB_USB
> >  1. How to use?
> >  1.1. Firmware
> >  
> > -Most of the USB drivers need to download a firmware to the device before start
> > +Most of the USB drivers need you to download a firmware to the device before start
> >  working.
> 
> The driver needs to download the firmware.  The user presumaby isn't
> doing this manually.  And "before start working" isn't entirely english
> either.
before start working was fixed later, fixed
> 
> >  Have a look at the Wikipage for the DVB-USB-drivers to find out, which firmware
> > @@ -127,7 +127,7 @@ http://www.linuxtv.org/wiki/index.php/DVB_USB
> >  
> >  Since the driver is in the linux kernel, activating the driver in
> >  your favorite config-environment should sufficient. I recommend
> > -to compile the driver as module. Hotplug does the rest.
> > +compiling the driver as module. Hotplug does the rest.
> 
> as a module?
fixed
> 
> >  If you use dvb-kernel enter the build-2.6 directory run 'make' and 'insmod.sh
> >  load' afterwards.
> 
> Rob

-- 
-Shawn Landden



>From 9bf4ff12f238a843cb1f3c082ca5eb3dafee426c Mon Sep 17 00:00:00 2001
From: Shawn Landden <shawnlandden@xxxxxxxxx>
Date: Sat, 5 May 2012 19:03:27 -0700
Subject: [PATCH] Documentation: fix up Documentation/dvb/README.dvb-usb


Signed-off-by: Shawn Landden <shawnlandden@xxxxxxxxx>
---
 Documentation/dvb/README.dvb-usb |   40 +++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/Documentation/dvb/README.dvb-usb b/Documentation/dvb/README.dvb-usb
index c4d963a..7e57501 100644
--- a/Documentation/dvb/README.dvb-usb
+++ b/Documentation/dvb/README.dvb-usb
@@ -6,7 +6,7 @@ Idea behind the dvb-usb-framework
 In March 2005 I got the new Twinhan USB2.0 DVB-T device. They provided specs and a firmware.
 
 Quite keen I wanted to put the driver (with some quirks of course) into dibusb.
-After reading some specs and doing some USB snooping, it realized, that the
+After reading some specs and doing some USB snooping, I realized, that the
 dibusb-driver would be a complete mess afterwards. So I decided to do it in a
 different way: With the help of a dvb-usb-framework.
 
@@ -115,8 +115,8 @@ http://www.linuxtv.org/wiki/index.php/DVB_USB
 1. How to use?
 1.1. Firmware
 
-Most of the USB drivers need to download a firmware to the device before start
-working.
+Most of the USB drivers need a firmware upload before they
+work.
 
 Have a look at the Wikipage for the DVB-USB-drivers to find out, which firmware
 you need for your device:
@@ -127,7 +127,7 @@ http://www.linuxtv.org/wiki/index.php/DVB_USB
 
 Since the driver is in the linux kernel, activating the driver in
 your favorite config-environment should sufficient. I recommend
-to compile the driver as module. Hotplug does the rest.
+compiling the driver as a module. Hotplug does the rest.
 
 If you use dvb-kernel enter the build-2.6 directory run 'make' and 'insmod.sh
 load' afterwards.
@@ -140,7 +140,7 @@ in the device).
 If you want to enable debug output, you have to load the driver manually and
 from within the dvb-kernel cvs repository.
 
-first have a look, which debug level are available:
+First have a look, at which debug levels are available:
 
 modinfo dvb-usb
 modinfo dvb-usb-vp7045
@@ -152,18 +152,18 @@ etc.
 
 should do the trick.
 
-When the driver is loaded successfully, the firmware file was in
-the right place and the device is connected, the "Power"-LED should be
-turned on.
+When the driver loads successfully, the firmware file is in
+the right place and the device is connected, the "Power"-LED should
+turn on.
 
-At this point you should be able to start a dvb-capable application. I'm use
-(t|s)zap, mplayer and dvbscan to test the basics. VDR-xine provides the
-long-term test scenario.
+At this point you should dvb applications should work. I use
+(t|s)zap, mplayer and dvbscan to test basic functionality. More testing is
+done with VDR-xine.
 
 2. Known problems and bugs
 
 - Don't remove the USB device while running an DVB application, your system
-  will go crazy or die most likely.
+  may crash.
 
 2.1. Adding support for devices
 
@@ -171,23 +171,23 @@ TODO
 
 2.2. USB1.1 Bandwidth limitation
 
-A lot of the currently supported devices are USB1.1 and thus they have a
-maximum bandwidth of about 5-6 MBit/s when connected to a USB2.0 hub.
+A lot of the currently supported devices are USB1.1 and thus have a
+maximum bandwidth of ~5-6 MBit/s when connected to a USB2.0 hub.
 This is not enough for receiving the complete transport stream of a
 DVB-T channel (which is about 16 MBit/s). Normally this is not a
 problem, if you only want to watch TV (this does not apply for HDTV),
 but watching a channel while recording another channel on the same
-frequency simply does not work very well. This applies to all USB1.1
+frequency simply does not work very well. (This applies to all USB1.1
 DVB-T devices, not just the dvb-usb-devices)
 
-The bug, where the TS is distorted by a heavy usage of the device is gone
-definitely. All dvb-usb-devices I was using (Twinhan, Kworld, DiBcom) are
-working like charm now with VDR. Sometimes I even was able to record a channel
-and watch another one.
+A bug where the TS is distorted by a heavy usage of the device has been
+squashed. All dvb-usb-devices I was using (Twinhan, Kworld, DiBcom) are
+now working like charm with VDR. Sometimes I even was able to record a channel
+will simultameously watching another one.
 
 2.3. Comments
 
-Patches, comments and suggestions are very very welcome.
+Patches, comments and suggestions are very welcome.
 
 3. Acknowledgements
    Amaury Demol (ademol@xxxxxxxxx) and Francois Kanounnikoff from DiBcom for
-- 
1.7.9.5


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux