On Mon, Jan 23, 2012 at 6:41 AM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote: >> +#ifdef CONFIG_PROC_FS > ^^^^^^^^^^^^^^^^^^^^^^ > > That ifdef is entertaining. CONFIG_SYSCTL depends on CONFIG_PROC_FS > so which interesting case did you imagine this ifdef would be false? > Did you test to ensure the code is not compiled in that interesting case? I noticed that when I added it, and decided to err on the side of more configs if some day /proc/sys got moved out of /proc. Anyway, I can easily remove it. v3 coming up... -Kees -- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html