On Fri, Sep 09, 2011 at 10:16:24AM +0100, Jonathan Cameron wrote: > On 09/09/11 09:31, Greg KH wrote: > > On Fri, Sep 09, 2011 at 05:22:26PM +0900, Donggeun Kim wrote: > >> SHARP GP2AP002 is proximity and ambient light sensor. > >> This patch supports it. > >> > >> Signed-off-by: Donggeun Kim <dg77.kim@xxxxxxxxxxx> > >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >> --- > >> Changes for v2 > >> - changed to expose lux > >> - changed request_irq to request_threaded_irq function > >> - added sysfs_notify function call > > > > Why? You should never do that unless you _really_ know what you are > > doing. > My bad. I suggested it was a better bet than doing a uevent to act > as a data ready notifier... > > Greg, for future reference can you clarify why it's a bad idea or > give a reference (if it's been clarified elsewhere and I missed it!) uevents are not for general "this sensor changed" type events. They are for "large" events like "your laptop got docked, your disk got removed, etc." They can be very "heavy" so don't use them lightly, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
