On 06/22, Vasiliy Kulikov wrote:
>
> +void exit_shm(struct task_struct *task)
> +{
> + struct nsproxy *nsp = task->nsproxy;
> + struct ipc_namespace *ns;
> +
> + if (!nsp)
> + return;
> + ns = nsp->ipc_ns;
> + if (!ns || !ns->shm_rmid_forced)
This looks confusing, imho. How it is possible that ->nsproxy or
->ipc_ns is NULL?
> + return;
> +
> + /* Destroy all already created segments, but not mapped yet */
> + down_write(&shm_ids(ns).rw_mutex);
> + idr_for_each(&shm_ids(ns).ipcs_idr, &shm_try_destroy_current, ns);
> up_write(&shm_ids(ns).rw_mutex);
Again, I do not pretend I understand ipc/, but it seems we can check
ns->ipc_ids[].in_use != 0 before the slow path, no?
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
