On Thu, 05 May 2011 20:04:48 +0530, Vikram Narayanan wrote: > On 05-05-2011 AM 01:09, Randy Dunlap wrote: > > On Thu, 5 May 2011 00:28:56 +0530 Vikram Narayanan wrote: > > > >>> On 04-05-2011 PM 11:57, Greg KH wrote: > >>> On Wed, May 04, 2011 at 11:40:02PM +0530, Vikram Narayanan wrote: > >>>> Hi, > >>>> > >>>> The i2c_device_id structure variable's name is not used in the > >>>> i2c_driver structure. > >>>> > >>>> Signed-off-by: Vikram Narayanan<vikram186@xxxxxxxxx> > >>>> --- > >>>> diff -ru a/Documentation/i2c/writing-clients > >>>> b/Documentation/i2c/writing-clients > >>>> --- a/Documentation/i2c/writing-clients 2011-05-04 22:48:19.956083316 > >>>> +0530 > >>>> +++ b/Documentation/i2c/writing-clients 2011-05-04 22:50:45.732054513 > >>>> +0530 > >>> Your patch is line-wrapped :( > >> > >> I am sorry. I know how annoying it is to tell everyone. I tried a > >> couple of mail clients, but still couldn't do it correctly. > >> > >>> Also, why are you copying me on this, I don't recall writing this file. > > > >> Since you are the maintainer of the Documentation, I thought to keep > >> you in the copy. I will make sure this is not repeated. :) > > > > You should Cc: the I2C subsystem maintainers for this patch. > > They are the ones who should merge it... > > although I am the Documentation/ tree maintainer. > The i2c_device_id structure variable's name is not used in the i2c_driver structure. > > Signed-off-by: Vikram Narayanan<vikram186@xxxxxxxxx> > --- > > diff -ru a/Documentation/i2c/writing-clients b/Documentation/i2c/writing-clients > --- a/Documentation/i2c/writing-clients 2011-05-04 22:48:19.956083316 +0530 > +++ b/Documentation/i2c/writing-clients 2011-05-04 22:50:45.732054513 +0530 > @@ -38,7 +38,7 @@ > .name = "foo", > }, > > - .id_table = foo_ids, > + .id_table = foo_idtable, > .probe = foo_probe, > .remove = foo_remove, > /* if device autodetection is needed: */ > Applied, thanks. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
