CC'd Dmitry Torokhov, the input maintainer. On 22.12.2010 11:50, Alexander Stein wrote: > features is a bit array, not byte array > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxxxxxx> Acked-by: Anssi Hannula <anssi.hannula@xxxxxx> with a minor nitpick below. > --- > This problem was already addressed in march 2009. See > http://www.spinics.net/lists/linux-input/msg03068.html Duh, apparently I forgot this, sorry. > Documentation/input/ff.txt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Documentation/input/ff.txt b/Documentation/input/ff.txt > index ded4d5f..e07072c 100644 > --- a/Documentation/input/ff.txt > +++ b/Documentation/input/ff.txt > @@ -49,7 +49,7 @@ This information is subject to change. > #include <linux/input.h> > #include <sys/ioctl.h> > > -unsigned long features[1 + FF_MAX/sizeof(unsigned long)]; > +unsigned long features[1 + FF_MAX/ (8 * sizeof(unsigned long))]; > int ioctl(int file_descriptor, int request, unsigned long *features); > > "request" must be EVIOCGBIT(EV_FF, size of features array in bytes ) Probably better to add a space after FF_MAX as well. -- Anssi Hannula -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
