Eric Cooper <ecc@xxxxxxx> writes: > Add a netdev LED trigger for all Blinkenlights lovers... > Originally taken from https://dev.openwrt.org/ticket/2776 > Slightly updated for 2.6.24 by Mickey Lauer <mickey@xxxxxxxxxxxx> > and for 2.6.36 by Eric Cooper <ecc@xxxxxxx> You should really send this to netdev too. Some comments: The timer seems power unfriendly -- it will always tick even if nothing happens. Using the device name as an identifier is not reliable, they may not be unique. rwlocks are deprecated. your store code has a off by one I think, it's possible to put not 0 terminated data in the string. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
