On Tue, 15 Jun 2010 01:55:14 +0100 Ben Hutchings wrote: > Andy Whitcroft wrote: > > We need the xmldoclinks built for any document types built from the > > XML sources. > > Indeed we do. So make the XML files depend on xmldoclinks. The patch description tells me what but not why. IOW, what error is this fixing and how do I produce that error when this patch is not applied? Thanks. > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > Acked-by: Andy Whitcroft <apw@xxxxxxxxxxxxx> > --- > --- a/Documentation/DocBook/Makefile > +++ b/Documentation/DocBook/Makefile > @@ -35,7 +35,7 @@ PS_METHOD = $(prefer-db2x) > PHONY += xmldocs sgmldocs psdocs pdfdocs htmldocs mandocs installmandocs cleandocs xmldoclinks > > BOOKS := $(addprefix $(obj)/,$(DOCBOOKS)) > -xmldocs: $(BOOKS) xmldoclinks > +xmldocs: $(BOOKS) > sgmldocs: xmldocs > > PS := $(patsubst %.xml, %.ps, $(BOOKS)) > @@ -95,7 +95,7 @@ define rule_docproc > ) > $(dir $@).$(notdir $@).cmd > endef > > -%.xml: %.tmpl FORCE > +%.xml: %.tmpl xmldoclinks FORCE > $(call if_changed_rule,docproc) > > ### > > -- > Ben Hutchings > Once a job is fouled up, anything done to improve it makes it worse. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html