Re: [PATCH] docbooks: Fix printk of IPv4 address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 17 Jul 2009 16:42:46 +0200 Tobias Klauser wrote:

> Use the %pI4 format string instead of %d.%d.%d.%d and NIPQUAD.
> 
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>

Hi,
Sorry for the delay in replying.

> ---
>  Documentation/DocBook/kernel-hacking.tmpl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/DocBook/kernel-hacking.tmpl b/Documentation/DocBook/kernel-hacking.tmpl
> index a50d6cd..9e47eb7 100644
> --- a/Documentation/DocBook/kernel-hacking.tmpl
> +++ b/Documentation/DocBook/kernel-hacking.tmpl
> @@ -450,7 +450,7 @@ printk(KERN_INFO "i = %u\n", i);
>  
>     <programlisting>
>  __u32 ipaddress;
> -printk(KERN_INFO "my ip: %d.%d.%d.%d\n", NIPQUAD(ipaddress));
> +printk(KERN_INFO "my ip: %pI4\n", ipaddress);

That should be                       &ipaddress);

but when I make that change, I get this error:

xmlto: input does not validate (status 1)
/lnx/src/TMP/linux-2.6.31-rc4-git3/Documentation/DocBook/kernel-hacking.xml:453: parser error : EntityRef: expecting ';'
printk(KERN_INFO "my ip: %pI4\n", &ipaddress);
                                            ^

and I haven't yet worked out how to get around it...


>     </programlisting>
>  
>     <para>
> -- 


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux