From: Julian Vetter > Sent: 21 October 2024 14:32 > > Thank you again for your remarks Arnd and Christoph! I have updated the > patchset, and placed the functions directly in asm-generic/io.h. I have > dropped the libs/iomem_copy.c and have updated/clarified the commit > message in the first patch. Apart from build 'issues' what is the justification for inlining these functions? They are quite large for inlining and some drivers could easily call them many times. The I/O cycles themselves are likely to be slow enough that the cost of a function call is pretty much likely to be noise. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)