On Thu, Jun 13, 2024 at 8:10 AM James Clark <james.clark@xxxxxxx> wrote: [...] > >> Reviewed-by: James Clark <james.clark@xxxxxxx> > >> > >> It does require a clean build to avoid some -fPIC errors presumably > >> because not everything that requires it gets rebuilt, for anyone who > >> gets stuck on that. > > > > We need to find a way to avoid requiring the 'make clean' :-/ > > > > - Arnaldo > > > > Do we need to make it so that if any of the Makefiles are touched it > does a clean? I'm assuming that was the cause of the issue I experienced > here and that the Makefile and/or Build files aren't mentioned as > dependencies of any target. Perhaps we can do something with the FEATURE_DUMP. It'd be nice to detect build argument changes and rebuild when that occurs. I'm used to doing lots of `make clean` due to sanitizer builds, something we should probably capture through features and/or `perf version --build-options`. Anyway, out-of-scope for these patches. I need to cut a v2 due to failing to add the new `.a` files to the clean target. Thanks for the review, Ian
