On Wed, Aug 16, 2023 at 08:48:30AM -0300, Arnaldo Carvalho de Melo wrote: [...] > > And move that to perf-tools-next, we can go on from there. > > > > The above is because we don't define CONFIG_PERF_REGS for these > > architectures and thus that variable ends up not being used, so I'm > > fixing up like below, in the cset where you made DWARF_MINIMAL_REGS > > receive the arch parameter. > > I added this to the cset commit message: > > Committer notes: > > Make DWARF_MINIMAL_REGS() an inline function, so that we can use the > __maybe_unused attribute for the 'arch' parameter, as this will avoid a > build failure when that variable is unused in the callers. That happens > when building on unsupported architectures, the ones without > HAVE_PERF_REGS_SUPPORT defined. Looks good to me, thanks for fixing. Leo
