On Wed, Dec 22, 2021 at 2:23 AM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Tue, Dec 21, 2021 at 5:35 PM <guoren@xxxxxxxxxx> wrote: > > + > > +config SYSVIPC_COMPAT > > + def_bool y > > + depends on COMPAT && SYSVIPC > > Can this be moved to init/Kconfig next to SYSVIPC? I would try another patchset, to see other architecture guys' advice. $ grep SYSVIPC_COMPAT arch -r arch/x86/Kconfig:config SYSVIPC_COMPAT arch/parisc/Kconfig:config SYSVIPC_COMPAT arch/powerpc/Kconfig:config SYSVIPC_COMPAT arch/arm64/Kconfig:config SYSVIPC_COMPAT arch/riscv/Kconfig:config SYSVIPC_COMPAT arch/s390/Kconfig:config SYSVIPC_COMPAT arch/mips/Kconfig:config SYSVIPC_COMPAT arch/mips/Kconfig: select SYSVIPC_COMPAT if SYSVIPC arch/mips/Kconfig: select SYSVIPC_COMPAT if SYSVIPC arch/sparc/Kconfig:config SYSVIPC_COMPAT > > > + > > +COMPAT_SYSCALL_DEFINE0(rt_sigreturn) > > +{ > > + return 0; > > +} > > This confused me a bit while reviewing, would it make sense to reorder the > patches to add the three missing functions first instead of adding the > dummy and then replacing it? Okay, I would try in the next version. Make the compile at last. > > > Arnd -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/