On Sat, Dec 18, 2021 at 2:16 PM Michał Mirosław <mirq-linux@xxxxxxxxxxxx> wrote:
>
> On Sat, Dec 18, 2021 at 01:19:57PM -0800, Yury Norov wrote:
> > Don't call bitmap_weight() if the following code can get by
> > without it.
> >
> > Signed-off-by: Yury Norov <yury.norov@xxxxxxxxx>
> > ---
> > drivers/net/dsa/b53/b53_common.c | 6 +-----
> > drivers/net/ethernet/broadcom/bcmsysport.c | 6 +-----
> > drivers/thermal/intel/intel_powerclamp.c | 9 +++------
> > 3 files changed, 5 insertions(+), 16 deletions(-)
> [...]
>
> Looks good,
Does it mean Acked-by, Reviewed-by, or something else?
> but I think this needs to be split per subsystem.
What you ask breaks rules:
Documentation/process/submitting-patches.rst:
Separate each **logical change** into a separate patch.
For example, if your changes include both bug fixes and performance
enhancements for a single driver, separate those changes into two
or more patches. If your changes include an API update, and a new
driver which uses that new API, separate those into two patches.
On the other hand, if you make a single change to numerous files,
group those changes into a single patch. Thus a single logical change
is contained within a single patch.
This is not a dead rule, refer for example the 96d4f267e40f9 ("Remove
'type' argument from access_ok() functioin.")
Or this: https://lkml.org/lkml/2021/6/14/1736
Thanks,
Yury
