Hi, Recently while staring at kprobes code for an unrelated task, I noticed some opportunities for improving the code. The first patch fixes a long standing bug in kprobes debug functionality. The remaining patches (marked RFC) refactor the code to increase code sharing, improve readability and remove redundancy. All feedback welcome. Thanks, Punit Punit Agrawal (5): kprobes: Do not use local variable when creating debugfs file kprobes: Use helper to parse boolean input from userspace kprobe: Simplify prepare_kprobe() by dropping redundant version csky: ftrace: Drop duplicate implementation of arch_check_ftrace_location() kprobes: Make arch_check_ftrace_location static arch/csky/kernel/probes/ftrace.c | 7 ---- include/linux/kprobes.h | 7 ++-- kernel/kprobes.c | 58 ++++++++++---------------------- 3 files changed, 23 insertions(+), 49 deletions(-) -- 2.30.2