> … were not released in a few error cases. … Another small wording adjustment: … in two error cases. … … > +++ b/drivers/irqchip/irq-csky-apb-intc.c … > @@ -126,10 +127,17 @@ ck_intc_init_comm(struct device_node *node, struct device_node *parent) … > +err_iounmap: > + iounmap(reg_base); > + return ret; > } … How do you think about to use the statement “return -ENOMEM;”? Can the local variable “ret” be omitted in this function implementation? Regards, Markus
