Hello, On Mon, 24 Jun 2019 11:41:33 +0800 guoren@xxxxxxxxxx wrote: > From: Guo Ren <ren_guo@xxxxxxxxx> > > The most thing is to use the toolchain compiled by buildroot itself. And > we also bump kernel to 5.0 with kernel.org. > > For all 610s including qemu we use 0x10000000 PHYS_OFFSET for unified > maintain. I'm not sure what you mean by "unified maintain". How does it matter, considering that the Buildroot defconfig is anyway for one single platform ? > There is no gx6605s.dts for the config, so we need wget it from > csky gitlab CI storage. Meh, this is not great. Is the Gitlab CI URL really permanent? Jobs artifacts are usually removed after a configurable time, isn't it the case as well for this artifact ? Also, why isn't this .dts not submitted to the upstream Linux kernel ? Overall, I think I would prefer to see a patch to the Linux kernel in board/csky/ rather than downloading a random .dtb. Or just have the .dts file directly in board/csky/. For the record, DT is not about "config", it's about describing the hardware. You might give the DT kernel maintainers a heart attack if you call the DT "configuration"! :-) Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
