Hello, On Wed, May 29, 2019 at 5:23 PM Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> wrote: > > Hello, > > On Wed, 29 May 2019 17:02:29 +0800 > Guo Ren <guoren@xxxxxxxxxx> wrote: > > > DSP is no use in current buildroot and gcc default enable the DSP > > feature for C-SKY. > > So DSP is part of our standard ISA, we needn't put it in -mcpu=xxx. > > "DSP is no use in current Buildroot" is not correct. The option exists, > and it changes the BR2_GCC_TARGET_CPU value. So it *is* used: it adds > "e" to BR2_GCC_TARGET_CPU. So this explanation is not really > good/sufficient. > > I am willing to help you formulate this properly, but since I still > don't understand why you are dropping the DSP option, I can't really > help by proposing a better wording. DSP extention is no longer used for C-SKY and there is no defconfig use "e" extension in buildroot. I have regretted submitting it to the buildroot. Change commit log, like this: Subject: Change DSP to VDSP for -mcpu DSP extention is no longer used for C-SKY gcc and there is no defconfig use "e" extension in buildroot. VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be supported by abiv2 (ck807, ck810, ck860). Is that OK? Best Regards Guo Ren