On Wed, May 29, 2019 at 5:02 PM Guo Ren <guoren@xxxxxxxxxx> wrote: > > On Wed, May 29, 2019 at 4:38 PM Thomas Petazzoni > <thomas.petazzoni@xxxxxxxxxxx> wrote: > > > > Hello, > > > > On Wed, 29 May 2019 16:12:25 +0800 > > Guo Ren <guoren@xxxxxxxxxx> wrote: > > > > > > Not just two patches: also a better commit log for the DSP -> VDSP > > > > change. > > > > > > I want these two patches: > > > > > > 1. Remove DSP, because it's no use in current buildroot. > > > 2. Add VDSP support > > > > OK, but then please split in yet another patch the fact of using > > arch.mk.csky to build the GCC_TARGET_CPU variable. > > I changemind and I'll follow the above patches which you prior mentioned > > - One switching to using arch.mk.sky, without changing DSP -> VDSP > - A follow-up one changing DSP -> VDSP, with a commit log that > explains why you make this chang > > > > > > Here is my commit log for Introduce VDSP feature: > > > > > > VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP > > > operation. It could be support by abiv2 (ck807, ck810, ck860). > > > > > > Is that OK? > > > > Yes. But please add a proper commit log in the patch removing the DSP > > option. > DSP -> VDSP, with a commit log, like this: > > Subject: Change DSP to VDSP for -mcpu > > DSP is no use in current buildroot and gcc default enable the DSP > feature for C-SKY. > So DSP is part of our standard ISA, we needn't put it in -mcpu=xxx. > > VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP > operation. It could be support by abiv2 (ck807, ck810, ck860). Correct: It is supported by abiv2.
