On Tue, Mar 11, 2025 at 11:13:52AM +0800, Herbert Xu wrote: > > > 5b855462cc7e3f3 Herbert Xu 2025-03-09 @174 if (req->dst && !dlen) > > ^^^^^^^^ > > Is this check necessary? > > This is not trying to catch a null req->dst, but it's trying to > detect an combination of a non-null req->dst with a zero dlen. > > A zero dlen is used to allocate req->dst on demand, which would > conflict with a non-null req->dst. Actually I take that back. Yes this test should be removed as it's a remnant of the NULL dst code which has no users. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
