On Sat, Mar 08, 2025 at 07:30:52PM -0500, Ethan Carter Edwards wrote: > We are trying to get rid of all multiplications from allocation > functions to prevent potential integer overflows. Here the > multiplication is probably safe, but using kcalloc() is more > appropriate and improves readability. This patch has no effect > on runtime behavior. > > Link: https://github.com/KSPP/linux/issues/162 [1] > Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > > Signed-off-by: Ethan Carter Edwards <ethan@xxxxxxxxxxxxxxxxx> Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx> > --- > drivers/crypto/axis/artpec6_crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c > index 1c1f57baef0ea9f4ecf7ab39f2c0e9e4327ef568..500b08e42282608348481b759e0b79d25f0b5db0 100644 > --- a/drivers/crypto/axis/artpec6_crypto.c > +++ b/drivers/crypto/axis/artpec6_crypto.c > @@ -2897,13 +2897,13 @@ static int artpec6_crypto_probe(struct platform_device *pdev) > tasklet_init(&ac->task, artpec6_crypto_task, > (unsigned long)ac); > > - ac->pad_buffer = devm_kzalloc(&pdev->dev, 2 * ARTPEC_CACHE_LINE_MAX, > + ac->pad_buffer = devm_kcalloc(&pdev->dev, 2, ARTPEC_CACHE_LINE_MAX, > GFP_KERNEL); > if (!ac->pad_buffer) > return -ENOMEM; > ac->pad_buffer = PTR_ALIGN(ac->pad_buffer, ARTPEC_CACHE_LINE_MAX); > > - ac->zero_buffer = devm_kzalloc(&pdev->dev, 2 * ARTPEC_CACHE_LINE_MAX, > + ac->zero_buffer = devm_kcalloc(&pdev->dev, 2, ARTPEC_CACHE_LINE_MAX, > GFP_KERNEL); > if (!ac->zero_buffer) > return -ENOMEM; > > --- > base-commit: 0a2f889128969dab41861b6e40111aa03dc57014 > change-id: 20250308-artpec6-devm_kcalloc-9a11cc6acb84 > > Best regards, > -- > Ethan Carter Edwards <ethan@xxxxxxxxxxxxxxxxx> /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@xxxxxxxx
