On Fri, Mar 07, 2025 at 01:43:49PM -0800, Eric Biggers wrote: > > This is okay (it makes it a bit easier to accidentally use addr after it was > unmapped, but it's probably worth the simplification in code), but I think using > 'void *__addr' would be more consistent with other places in the kernel that use > a similar trick to have something both const and non-const. For example > struct inode in include/linux/fs.h has i_nlink and __i_nlink. OK I'll rename this. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt