On Tue, Feb 18, 2025 at 05:48:10PM +0000, Eric Biggers wrote: > > In addition, your (slower) solution has a large amount of complexity in the > per-algorithm glue code, making it still more lines of code *per algorithm* than > my (faster) solution, which you're ignoring. My patches make the per-alg glue code look bad, but the intention is to share them not just between sha256 implementatinos, but across all ahash implementations as a whole. They will become the new hash walking interface. > Anyway, I am getting tired of responding to all your weird arguments that don't > bring anything new to the table. Please continue to treat your patches as > nacked and don't treat silence as agreement. I am just tired of this. Talk about weird arguments, here's something even weirder to ponder over: Rather than passing a single block, let's pass the whole bio all at once. Then depending on how much memory is available to store the hash result, we either return the whole thing, or hash as much as we can fit into a page and then iterate (just a single hash in the worst case (OOM)). Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
