On Wed, Feb 12, 2025 at 07:47:11AM -0800, Eric Biggers wrote: > [ This patchset keeps getting rejected by Herbert, who prefers a > complex, buggy, and slow alternative that shoehorns CPU-based hashing > into the asynchronous hash API which is designed for off-CPU offload: > https://lore.kernel.org/linux-crypto/cover.1730021644.git.herbert@xxxxxxxxxxxxxxxxxxx/ > This patchset is a much better way to do it though, and I've already > been maintaining it downstream as it would not be reasonable to go the > asynchronous hash route instead. Let me know if there are any > objections to me taking this patchset through the fsverity tree, or at > least patches 1-5 as the dm-verity patches could go in separately. ] Yes I object. While I very much like this idea of parallel hashing that you're introducing, shoehorning it into shash is restricting this to storage-based users. Networking is equally able to benefit from paralell hashing, and parallel crypto (in particular, AEAD) in general. In fact, both TLS and IPsec can benefit directly from bulk submission instead of the current scheme where a single packet is processed at a time. But thanks for the reminder and I will be posting my patches soon. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
