On Thu, Dec 26, 2024 at 07:08:03PM +0100, Lukas Wunner wrote:
>
> diff --git a/crypto/ecdsa-p1363.c b/crypto/ecdsa-p1363.c
> index eaae7214d69b..c4f458df18ed 100644
> --- a/crypto/ecdsa-p1363.c
> +++ b/crypto/ecdsa-p1363.c
> @@ -21,7 +21,7 @@ static int ecdsa_p1363_verify(struct crypto_sig *tfm,
> const void *digest, unsigned int dlen)
> {
> struct ecdsa_p1363_ctx *ctx = crypto_sig_ctx(tfm);
> - unsigned int keylen = crypto_sig_keysize(ctx->child);
> + unsigned int keylen = DIV_ROUND_UP(crypto_sig_keysize(ctx->child), 8);
This may overflow unnecessarily, please rewrite these as:
X / 8 + !!(X & 7)
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
