On Mon, Nov 25, 2024 at 1:54 PM Sridhar, Kanchana P <kanchana.p.sridhar@xxxxxxxxx> wrote: > > There are some minimal "future-proofing" details such as: I don't think they're minimal :) > > 1) The folio_batch: This is the most contentious, I believe, because it > is aimed toward evolving the zswap_batch_store() interface for > reclaim batching, while allowing the folio-error association for the > partial benefits provided by (2). As mentioned earlier, I can delete this > in the next rev if the maintainers feel strongly about this. Let's delete it, and focus on the low hanging fruit (large folio zswap storing). > 2) int* error signature: benefit can be realized today due to the latency > optimization it enables from detecting errors early, localized cleanup, > preventing unwinding state. That said, the same benefits can be realized > without making it a part of the interface. This can be done in a separate patch/follow up. It's not related to this work :)
