On Fri, Nov 29, 2024 at 08:46:58AM +0100, Lukas Wunner wrote:
>
> @@ -185,6 +187,16 @@ static int rsassa_pkcs1_sign(struct crypto_sig *tfm,
> if (slen + hash_prefix->size > ctx->key_size - 11)
> return -EOVERFLOW;
>
> + /*
> + * Only kmalloc virtual addresses shall be used in a scatterlist,
> + * so duplicate src if it points e.g. into kernel or module rodata.
> + */
> + if (!virt_addr_valid(src)) {
Please don't do this. You cannot turn a virtual address into
an SG list in general. This is just one of the many failure
scenarios.
The only safe way to do this is for the user to tell us that it's
OK.
So please switch over to the sync interface.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
