Re: [PATCH v4 01/10] crypto: acomp - Define two new interfaces for compress/decompress batching.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 27, 2024 at 01:22:40AM +0000, Sridhar, Kanchana P wrote:
>
> 1) It appears a calling module like zswap would only be able to get 1 error
>      status for all the requests that are chained, as against individual error
>      statuses for each of the [de]compress jobs. Is this understanding correct?

No, each request gets its own error in req->base.err.

> 2) The request chaining makes use of the req->base.complete and req->base.data,
>      which are also used for internal data by the iaa_crypto driver. I can add another
>      "void *data1" member to struct crypto_async_request to work around this,
>      such that iaa_crypto uses "data1" instead of "data".

These fields are meant for the user.  It's best not to use them
to store driver data, but if you really wanted to, then the API
ahash code provides an example of doing it (please only do this
as a last resort as it's rather fragile).

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux