On Thu, Oct 10, 2024 at 12:45:16PM -0700, Rosen Penev wrote: > > @@ -566,21 +572,16 @@ static int mv_cesa_probe(struct platform_device *pdev) > return 0; > > err_cleanup: > - for (i = 0; i < caps->nengines; i++) > - mv_cesa_put_sram(pdev, i); > - > + mv_cesa_put_sram(pdev); I think it'd be cleaner if you introduced a new function that did the loop and kept mv_cesa_put_sram as is. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
