On Wed, 16 Oct 2024 13:36:12 +0800
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> This patch should fix the problem and I'll push it into 6.12-rc.
>
> commit 6100da511bd21d3ccb0a350c429579e8995a830e
> Author: Qianqiang Liu <qianqiang.liu@xxxxxxx>
> Date: Fri Sep 13 22:07:42 2024 +0800
>
> crypto: lib/mpi - Fix an "Uninitialized scalar variable" issue
>
> The "err" variable may be returned without an initialized value.
>
> Fixes: 8e3a67f2de87 ("crypto: lib/mpi - Add error checks to extension")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@xxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>
> diff --git a/lib/crypto/mpi/mpi-mul.c b/lib/crypto/mpi/mpi-mul.c
> index 892a246216b9..7e6ff1ce3e9b 100644
> --- a/lib/crypto/mpi/mpi-mul.c
> +++ b/lib/crypto/mpi/mpi-mul.c
> @@ -21,7 +21,7 @@ int mpi_mul(MPI w, MPI u, MPI v)
> int usign, vsign, sign_product;
> int assign_wp = 0;
> mpi_ptr_t tmp_limb = NULL;
> - int err;
> + int err = 0;
>
> if (u->nlimbs < v->nlimbs) {
> /* Swap U and V. */
> --
I can confirm your patch fixes the issue. Thanks!
Regards,
Erhard
