On Tue, Oct 15, 2024 at 04:15:15PM +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel <ardb@xxxxxxxxxx> > > crc32-generic and crc32c-generic are built around the architecture > library code for CRC-32, and the lack of distinct drivers for this arch > code means they are lacking test coverage. > > Fix this by providing another, truly generic driver built on top of the > generic C code when fuzz testing is enabled. Wouldn't it make more sense to make crc32-generic actually be the generic implementation, and add crc32-arm64 and crc32-riscv? Likewise for crc32c. That is the usual way that the algorithms get wired up. Even if we take a shortcut and don't do that, the naming could at least be more consistent, e.g. rename the existing crc32-generic to crc32-lib and add crc32-generic alongside that. - Eric
