On Tue, Oct 15, 2024 at 02:41:34PM +0200, Ondrej Mosnacek wrote: > On Mon, Oct 7, 2024 at 3:33 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > > > Instead of using a struct of function pointers to decide whether to call > > the encryption or decryption assembly functions, use a conditional > > branch on a bool. Force-inline the functions to avoid actually > > generating the branch. This improves performance slightly since > > indirect calls are slow. Remove the now-unnecessary CFI stubs. > > Wouldn't the compiler be able to optimize out the indirect calls > already if you merely force-inline the functions without the other > changes? Then again, it's just a few places that grow the if-else, so > I'm fine with the boolean approach, too. There's no guarantee that the compiler will actually optimize out the indirect calls that way. - Eric
