Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> On Mon, Sep 23, 2024 at 8:48 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > On Mon, Sep 23, 2024 at 04:06:41PM +0800, Xi Ruoyao wrote: > > On Mon, 2024-09-23 at 15:15 +0800, Huacai Chen wrote: > > > > +#define line3 state12, state13, state14, state15 > > > > + > > > > +#define line1_perm state5, state6, state7, state4 > > > > +#define line2_perm state10, state11, state8, state9 > > > > +#define line3_perm state15, state12, state13, state14 > > > > + > > > > +#define copy copy0, copy1, copy2, copy3 > > > The indentation here is strange, it seems some of them are spaces and > > > some of them are tabs. > > > > Oops indeed. The tabs after "#define" should be a space instead. > > > > Jason: can you edit it for me or do you want a new revision of the patch > > I've fixed it in tree. > > Jason
