On Wed, Sep 11, 2024 at 04:02:03PM +0300, Jarkko Sakkinen wrote: > On Tue Sep 10, 2024 at 5:30 PM EEST, Lukas Wunner wrote: > > crypto_sig_maxsize() is a bit of a misnomer as it doesn't return the > > maximum signature size, but rather the key size. > > > > Rename it as well as all implementations of the ->max_size callback. > > A subsequent commit introduces a crypto_sig_maxsize() function which > > returns the actual maximum signature size. > > > > While at it, change the return type of crypto_sig_keysize() from int to > > unsigned int for consistency with crypto_akcipher_maxsize(). None of > > the callers checks for a negative return value and an error condition > > can always be indicated by returning zero. > > Why this is so late in the series? Because it's a prerequisite for the subsequent patch. Thanks, Lukas