Re: [RESEND. PATCH v2] MIPS: crypto: Clean up useless assignment operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 06, 2024 at 11:46:05AM +0800, WangYuli wrote:
>
> diff --git a/arch/mips/crypto/crc32-mips.c b/arch/mips/crypto/crc32-mips.c
> index ec6d58008f8e..3a80b7576ec3 100644
> --- a/arch/mips/crypto/crc32-mips.c
> +++ b/arch/mips/crypto/crc32-mips.c
> @@ -77,36 +77,29 @@ static u32 crc32_mips_le_hw(u32 crc_, const u8 *p, unsigned int len)
>  {
>  	u32 crc = crc_;
>  
> -#ifdef CONFIG_64BIT
> -	while (len >= sizeof(u64)) {
> +#if IS_ENABLED(CONFIG_64BIT)

That's not how we normally use IS_ENABLED.  The point of having
it is so that you can embed it into the C code directly, i.e.:

	if (IS_ENABLED(CONFIG_64BIT))

Please also refrain from making unrelated changes like removing
blank lines in the same patch as it makes it more difficult to
see what you're actually changing.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux