Re: [PATCH -next] crypto: Remove unused parameter from macro ROLDQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/8/30 18:12, Herbert Xu wrote:
On Fri, Aug 23, 2024 at 02:57:07PM +0800, Hongbo Li wrote:
The parameter w1 is not used in macro ROLDQ, so we can
remove it to simplify the code.

Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx>
---
  crypto/camellia_generic.c | 42 +++++++++++++++++++--------------------
  1 file changed, 21 insertions(+), 21 deletions(-)

I don't think the churn caused by this change is worth it.

Although it seems a bit risky, the new code does not have to consider passing in unnecessary arguments when using the ROLDQ macro. Of course, I'm not sure if there will be other new places using it.

Thanks,
Hongbo

Cheers,




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux