Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes: > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source of this email and know the content is safe. > Report Suspicious > > On Thu, 22 Aug 2024 02:32:52 +0530 Kamlesh Gurudasani <kamlesh@xxxxxx> wrote: > >> In the case where we are forcing the ps.chunk_size to be at least 1, >> we are ignoring the caller's alignment. >> >> Move the forcing of ps.chunk_size to be at least 1 before rounding it >> up to caller's alignment, so that caller's alignment is honored. >> >> While at it, use max() to force the ps.chunk_size to be at least 1 to >> improve readability. > > Please (as always) describe the userspace-visible runtime effects of > this change. This helps others to determine which kernel(s) should be > patched. And it helps others decide whether this fix might address an > issue which they are encountering. Thanks for the review, Andrew. Honestly, I'm not sure the effects would be visble to userspace or not. or even how to reproduce it. I have fixed according to discussion here, https://patchwork.kernel.org/project/linux-crypto/patch/20240806174647.1050398-1-longman@xxxxxxxxxx/#25984314 Kamlesh
