On Thu, Aug 22, 2024 at 02:32:52AM GMT, Kamlesh Gurudasani wrote: > In the case where we are forcing the ps.chunk_size to be at least 1, > we are ignoring the caller's alignment. > > Move the forcing of ps.chunk_size to be at least 1 before rounding it > up to caller's alignment, so that caller's alignment is honored. > > While at it, use max() to force the ps.chunk_size to be at least 1 to > improve readability. > > Fixes: 6d45e1c948a8 ("padata: Fix possible divide-by-0 panic in padata_mt_helper()") Looks fine. Acked-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx> > Signed-off-by: Kamlesh Gurudasani <kamlesh@xxxxxx> > --- > kernel/padata.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/kernel/padata.c b/kernel/padata.c > index 0fa6c2895460..d8a51eff1581 100644 > --- a/kernel/padata.c > +++ b/kernel/padata.c > @@ -509,21 +509,17 @@ void __init padata_do_multithreaded(struct padata_mt_job *job) > > /* > * Chunk size is the amount of work a helper does per call to the > - * thread function. Load balance large jobs between threads by > + * thread function. Load balance large jobs between threads by Though whitespace changes like these just add noise...