On Mon, 2024-08-19 at 07:34 -0700, Jeff Johnson wrote:
> On 8/18/24 09:57, Roberto Sassu wrote:
> ...
> > diff --git a/crypto/asymmetric_keys/pgp_library.c b/crypto/asymmetric_keys/pgp_library.c
> > new file mode 100644
> > index 000000000000..33ed01f67654
> > --- /dev/null
> > +++ b/crypto/asymmetric_keys/pgp_library.c
> > @@ -0,0 +1,272 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* PGP packet parser (RFC 4880)
> > + *
> > + * Copyright (C) 2011 Red Hat, Inc. All Rights Reserved.
> > + * Written by David Howells (dhowells@xxxxxxxxxx)
> > + */
> > +
> > +#define pr_fmt(fmt) "PGPL: "fmt
> > +#include <linux/errno.h>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +
> > +#include "pgplib.h"
> > +
> > +MODULE_LICENSE("GPL");
>
> Missing MODULE_DESCRIPTION()
>
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning when built with make W=1. Recently, multiple
> developers have been eradicating these warnings treewide, and very few
> are left, so please don't introduce a new one :)
Uhm, checked it. Built the kernel with W=n and didn't see it. Also, I
need to build the PGP code as module (W=1) for the message to appear
(if you select the preloading facility, the config option switches to
built-in).
Thanks
Roberto
