Hi Herbert, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-api-Do-not-wait-for-tests-during-registration/20240810-160343 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master patch link: https://lore.kernel.org/r/ZrbTfOViUr3S4V7X%40gondor.apana.org.au patch subject: [PATCH 2/3] crypto: api - Do not wait for tests during registration config: x86_64-randconfig-161-20240811 (https://download.01.org/0day-ci/archive/20240811/202408110413.vKk2q3qN-lkp@xxxxxxxxx/config) compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202408110413.vKk2q3qN-lkp@xxxxxxxxx/ smatch warnings: crypto/algapi.c:396 crypto_alg_tested() error: uninitialized symbol 'test'. vim +/test +396 crypto/algapi.c 73d3864a4823ab Herbert Xu 2008-08-03 350 void crypto_alg_tested(const char *name, int err) 73d3864a4823ab Herbert Xu 2008-08-03 351 { 73d3864a4823ab Herbert Xu 2008-08-03 352 struct crypto_larval *test; 73d3864a4823ab Herbert Xu 2008-08-03 353 struct crypto_alg *alg; 73d3864a4823ab Herbert Xu 2008-08-03 354 struct crypto_alg *q; 73d3864a4823ab Herbert Xu 2008-08-03 355 LIST_HEAD(list); 73d3864a4823ab Herbert Xu 2008-08-03 356 73d3864a4823ab Herbert Xu 2008-08-03 357 down_write(&crypto_alg_sem); 73d3864a4823ab Herbert Xu 2008-08-03 358 list_for_each_entry(q, &crypto_alg_list, cra_list) { b8e15992b420d0 Herbert Xu 2009-01-28 359 if (crypto_is_moribund(q) || !crypto_is_larval(q)) 73d3864a4823ab Herbert Xu 2008-08-03 360 continue; Is it possible for everything to be moribund or larval? 73d3864a4823ab Herbert Xu 2008-08-03 361 73d3864a4823ab Herbert Xu 2008-08-03 362 test = (struct crypto_larval *)q; 73d3864a4823ab Herbert Xu 2008-08-03 363 73d3864a4823ab Herbert Xu 2008-08-03 364 if (!strcmp(q->cra_driver_name, name)) 73d3864a4823ab Herbert Xu 2008-08-03 365 goto found; 73d3864a4823ab Herbert Xu 2008-08-03 366 } 73d3864a4823ab Herbert Xu 2008-08-03 367 c72358571aaadf Karim Eshapa 2017-05-13 368 pr_err("alg: Unexpected test result for %s: %d\n", name, err); 73d3864a4823ab Herbert Xu 2008-08-03 369 goto unlock; This calling crypto_alg_put() on the last item in the list seems wrong either way. 73d3864a4823ab Herbert Xu 2008-08-03 370 73d3864a4823ab Herbert Xu 2008-08-03 371 found: b8e15992b420d0 Herbert Xu 2009-01-28 372 q->cra_flags |= CRYPTO_ALG_DEAD; 73d3864a4823ab Herbert Xu 2008-08-03 373 alg = test->adult; d6097b8d5d55f2 Nicolai Stange 2022-02-21 374 d6097b8d5d55f2 Nicolai Stange 2022-02-21 375 if (list_empty(&alg->cra_list)) 73d3864a4823ab Herbert Xu 2008-08-03 376 goto complete; 73d3864a4823ab Herbert Xu 2008-08-03 377 d6097b8d5d55f2 Nicolai Stange 2022-02-21 378 if (err == -ECANCELED) d6097b8d5d55f2 Nicolai Stange 2022-02-21 379 alg->cra_flags |= CRYPTO_ALG_FIPS_INTERNAL; d6097b8d5d55f2 Nicolai Stange 2022-02-21 380 else if (err) 73d3864a4823ab Herbert Xu 2008-08-03 381 goto complete; d6097b8d5d55f2 Nicolai Stange 2022-02-21 382 else d6097b8d5d55f2 Nicolai Stange 2022-02-21 383 alg->cra_flags &= ~CRYPTO_ALG_FIPS_INTERNAL; 73d3864a4823ab Herbert Xu 2008-08-03 384 73d3864a4823ab Herbert Xu 2008-08-03 385 alg->cra_flags |= CRYPTO_ALG_TESTED; 73d3864a4823ab Herbert Xu 2008-08-03 386 103961609b0935 Herbert Xu 2024-08-10 387 crypto_alg_finish_registration(alg, &list); cce9e06d100df1 Herbert Xu 2006-08-21 388 73d3864a4823ab Herbert Xu 2008-08-03 389 complete: 862e4618d9321e Herbert Xu 2024-08-10 390 list_del_init(&test->alg.cra_list); 73d3864a4823ab Herbert Xu 2008-08-03 391 complete_all(&test->completion); 2825982d9d66eb Herbert Xu 2006-08-06 392 73d3864a4823ab Herbert Xu 2008-08-03 393 unlock: 73d3864a4823ab Herbert Xu 2008-08-03 394 up_write(&crypto_alg_sem); 2825982d9d66eb Herbert Xu 2006-08-06 395 862e4618d9321e Herbert Xu 2024-08-10 @396 crypto_alg_put(&test->alg); ^^^^ 73d3864a4823ab Herbert Xu 2008-08-03 397 crypto_remove_final(&list); cce9e06d100df1 Herbert Xu 2006-08-21 398 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
