On 7/29/2024 12:16 PM, Herbert Xu wrote: > Switch cpumask_t to cpumask_var_t as the former may be too big > for the stack: > > CC [M] drivers/crypto/caam/caamalg_qi2.o > ../drivers/crypto/caam/caamalg_qi2.c: In function ‘dpaa2_dpseci_setup’: > ../drivers/crypto/caam/caamalg_qi2.c:5135:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] > 5135 | } > | ^ > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Reviewed-by: Horia Geantă <horia.geanta@xxxxxxx> though I have a few comments: 1. This patch does not apply cleanly on crypto tree Patch depends on the patch set https://lore.kernel.org/linux-crypto/20240702185557.3699991-1-leitao@xxxxxxxxxx/ which was merged via net-next. I assume the dependency will be fixed with the crypto tree moving to v6.11-rc1. 2. I was not able to reproduce the issue I tried on arm64 and i386 (with COMPILE_TEST=y) defconfigs. I could reproduce the issue on arm64 only when modifying CONFIG_FRAME_WARN=2048 -> 1024. Still, I would like to know your configuration, since there is a similar case in caam_qi_init() (drivers/crypto/caam/qi.c) which might need attention too. Thanks, Horia
