Re: [PATCH v2 2/3] crypto: X25519 core functions for ppc64le

Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> · Thu, 18 Jul 2024 17:25:08 -0700

On 5/16/24 08:19, Danny Tsen wrote:
X25519 core functions to handle scalar multiplication for ppc64le.

Signed-off-by: Danny Tsen <dtsen@xxxxxxxxxxxxx>
---
  arch/powerpc/crypto/curve25519-ppc64le-core.c | 299 ++++++++++++++++++
  1 file changed, 299 insertions(+)
  create mode 100644 arch/powerpc/crypto/curve25519-ppc64le-core.c
...

+MODULE_ALIAS_CRYPTO("curve25519");
+MODULE_ALIAS_CRYPTO("curve25519-ppc64le");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Danny Tsen <dtsen@xxxxxxxxxx>");

Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. I'm in the process of building 
ppc64le with CRYPTO_CURVE25519_PPC64=m to validate my suspicion, but I 
expect this to generate a warning.

Can you submit a follow-up patch that adds a MODULE_DESCRIPTION()?
And since I'm trying to fix all of the existing issues in 6.11, Herbert 
can you push this to Linus when it lands?

Thanks,
/jeff