Hi Suren, On Thu, Jul 18, 2024 at 6:49 PM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > Warning: It is no longer safe to dereference vma-> after this point, because mmap_lock is dropped, so vma might be destroyed from underneath us. > > Better but I would change "mmap_lock is dropped" to "mmap_lock might > have been dropped by __handle_mm_fault()" because mmap_lock is not > always dropped by __handle_mm_fault(). Technicality but better be > clear about it. > With that changed feel free to add: > > Reviewed-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> Will do. Thanks, Jason