Re: [PATCH] crypto: testmgr - generate power-of-2 lengths more often

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Implementations of hash functions often have special cases when lengths
> are a multiple of the hash function's internal block size (e.g. 64 for
> SHA-256, 128 for SHA-512).  Currently, when the fuzz testing code
> generates lengths, it doesn't prefer any length mod 64 over any other.
> This limits the coverage of these special cases.
> 
> Therefore, this patch updates the fuzz testing code to generate
> power-of-2 lengths and divide messages exactly in half a bit more often.
> 
> Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
> 
> This is the same as
> https://lore.kernel.org/linux-crypto/20240621165922.77672-3-ebiggers@xxxxxxxxxx/,
> just resent as a standalone patch.
> 
> crypto/testmgr.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux